Re: module unload deadlock

From: viro
Date: Wed Feb 18 2004 - 12:39:22 EST


On Wed, Feb 18, 2004 at 06:24:46PM +0100, Andrea Arcangeli wrote:
> The one you propose (of parport_pc keeping track of the ports by itself)
> is a different model, currently it's the highlevel that keeps track of
> the ports and each lowlevel registers the lowlevel ports in the
> highlevel list of ports. It doesn't mean the current model is wrong. You
> may not like it and you may find it less efficient, or less clean, or
> whatever, but the current model is definitely legitimate (the parport
> code has the troubles you found in the sharing code locking, but this
> registration model you're complaining about now is legitimate instead).

RTFS. And realize that parport_enumerate() exports the damn list with no
protection whatsoever. It is broken and it always had been broken.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/