Recommendation: [PATCH] SIS AGP 648[FX] cleaned+fixed ...

[Oliver Schoett]

"Heilmann, Oliver" <Oliver.Heilmann@xxxxxxxx> writes:

 > This patch is provides AGP support for sis 648 and 648FX chipsets
 > (previous versions only worked on FX chipsets).

I would like to point out how important this patch is.  My Motherboard
(Microstar MS-6701, branded MD-5000) has a SIS 648 north bridge, and
for months before the patch, I have observed the following: on a
freshly booted system, after

   insmod agpgart
   insmod sis-agp
   insmod fglrx            (the binary kernel module from ATI)
   /etc/init.d/xdm start   (start X server)

the machine would always lock up completely: black screen, no IDE disk
I/O, no Ctrl-Alt-Backsp or Ctrl-Alt-F1, only the SysRq keys worked.  I
have actually lost data due to the blocked disk I/O when experimenting
with this.  The problem has been consistent for the entire 2.6.0-test*
and 2.6.* kernel series and for various versions of the binary ATI
drivers for my ATI 9600TX graphics card.

The patch by Oliver Heilmann makes the above process work flawlessly
on my machine on kernels 2.6.2 and 2.6.3, and with variations such als
letting sis-agp pull in agpgart and letting the X server pull in the
fglrx module.

(Actually, for my SIS 648 chip, just the 10ms timeout is enough, but I
have read reports on the gentoo board by SIS 648FX owners that the
patch turned their graphics cards from not working to working with DRI
for the first time.)

This patch is an important contribution for owners of the common SIS
648 and SIS 648FX north bridge chips, and I therefore recommend it for
inclusion in the kernel AGP driver.

Regards,

Oliver Schoett

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/