Re: [linux-usb-devel] Re: [BK PATCH] USB update for 2.6.3

[Benjamin Herrenschmidt]

> Well, usb_device->bus->controller is the only access that
> should be needed ... much prettier than a tree walk!  It's
> set up as part of device enumeration.
> 
> Some of the usb_buffer_*() mapping calls could probably
> start to get inlined now, using the generic DMA calls.

It all depends what the USB device driver does. If it does
pass the struct device of it's controller, it's fine. If we
want it to be able to pass its own struct device, we need
this walk... it's a matter of how we want this API to behave.

Same goes for firewire, and possibly others

Anyway, a platform hook in device_add() seem like it could be
useful for other things as well...

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/