Re: Double fb_console_init call during do_initcalls

[Randy.Dunlap]

On Fri, 20 Feb 2004 12:12:30 +0000 Jonathan Brown <jbrown@xxxxxxxxxxxxxxxx> wrote:

| fb_console_init gets called twice during do_initcalls. Should it be 
| called from vty_init or as its own initcall? If it should be its own 
| initcall then can it be moved up the list to occur sooner? I think it 
| looks better if the fb kicks in as early as possible.
| 
| 
|   [<c01d09cc>] take_over_console+0x14a/0x1c9
|   [<c031e4c5>] fb_console_init+0x2b/0x59
|   [<c031cde4>] vty_init+0xc9/0xd3
|   [<c031c5b1>] tty_init+0x234/0x23c
|   [<c0310610>] do_initcalls+0x32/0x80
|   [<c01050a6>] init+0x2f/0x109
|   [<c0105077>] init+0x0/0x109
|   [<c0106a81>] kernel_thread_helper+0x5/0xb
| Console: switching to colour frame buffer device 128x48
| 
| 
|   [<c01d09cc>] take_over_console+0x14a/0x1c9
|   [<c031e4c5>] fb_console_init+0x2b/0x59
|   [<c0310610>] do_initcalls+0x32/0x80
|   [<c01050a6>] init+0x2f/0x109
|   [<c0105077>] init+0x0/0x109
|   [<c0106a81>] kernel_thread_helper+0x5/0xb
| Console: switching to colour frame buffer device 128x48
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Ugh.  fb_console_init() can be called by
drivers/char/vt.c (one initcall) or drivers/video/fbmem.c or
drivers/video/console/fbcon.c (<-- module_init/initcall).

It definitely wants to be cleaned up, but changing initcall
order can be "fragile".  Have you tried/tested it?

Or maybe James Simmons has some updates for this.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/