Re: kernel too big

[H. Peter Anvin]

Andries.Brouwer@xxxxxx wrote:
> +
> +	if ((is_big_kernel && end && end > 0xc0c00000) ||
> +	    (!is_big_kernel && sys_size > DEF_SYSSIZE)) {


The only issue I see here is that is_big_kernel is actually wrong, the
correct logic should be:


if ((end && end > 0xc0c00000) ||
    (!is_big_kernel && sys_size > DEF_SYSSIZE))

Not that it matters much, but it's correct that way.

I would also feel a lot happier if this was actually defined
symbolically somewhere, and there was a comment connecting it to head.S.

Alternative I could take a stab at making these tables auto-generated
and therefore completely eliminate this dependency for bzImage.

	-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/