Re: Fix silly thinko in sungem network driver.

[Benjamin Herrenschmidt]

And some more data:

Apple .h says:

#define kConfiguration_Infinite_Burst	0x00000001	// for Tx only
#define kConfiguration_RonPaulBit		0x00000800	// for pci reads at end of infinite burst, next command is memory read multiple
#define kConfiguration_EnableBug2Fix	0x00001000	// fix Rx hang after overflow

And the OF firmware (forth) driver does:

config rl@ 801 or config rl!

Which is interesting, that is it sets the RonPaulBit and the Infinite
Burst bit, and doesn't test the result...

Linus, does your G5 infinite burst bit sticks at all ? I think the
idea is that _older_ apple ones didn't have infinite burst, while newer
(G5) ones do, but also need the bug fix bits.

Which means the code Linus has is ok (without my latest patch).

Ben.




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/