Re: 2.6.2-rc3 messages BUG

[Chris Wright]

* Andrew Morton (akpm@xxxxxxxx) wrote:
> > [root@mdk9 root]# lsmod
> > Module                  Size  Used by
> > uhci_hcd               31752  0
> > cdc_acm                10784  3
> > usbcore               111828  4 uhci_hcd,cdc_acm
> > [root@mdk9 root]# rmmod uhci_hcd
> > [root@mdk9 root]# insmod
> > /lib/modules/2.6.3-rc2/kernel/drivers/usb/host/uhci-hcd.ko
> 
> You missed out an important piece of info.  The kernel should have printed
> out "kmem_cache_create: duplicate cache <name>" before going BUG.
> 
> What was "<name>"?  uhci_urb_priv?
> 
> I suggest you go into drivers/usb/host/uhci-hcd.c:uhci_hcd_cleanup() and
> replace
> 
> 	warn("not all urb_priv's were freed!");
> 
> with
> 
> 	BUG();
> 
> because failure to destroy that slab cache is fatal, and it points at a bug
> in this driver.

True, I mentioned this to Greg earlier.  But in this case that BUG() is
only going to show the rmmod attempt, right?  Problem is that rmmod
works when the driver is in use, and this only happens after
suspend/resume.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/