[PATCH 2.6] Another oops in i2c-core with debug

From: Jean Delvare
Date: Sun Feb 22 2004 - 07:29:46 EST


Hi Greg,

Some times ago, you fixed an oops in i2c-core when debugging is enabled:
http://marc.theaimsgroup.com/?l=linux-kernel&m=107585749612115&w=2

Looks like you missed that second one:

--- linux-2.6.3/drivers/i2c/i2c-core.c 2004-02-18 20:18:14.000000000 +0100
+++ linux-2.6.3-i2c/drivers/i2c/i2c-core.c 2004-02-22 13:04:11.000000000 +0100
@@ -618,7 +618,7 @@
int ret = 0;
struct i2c_adapter *adap = client->adapter;

- dev_dbg(&client->dev, "i2c ioctl, cmd: 0x%x, arg: %#lx\n", cmd, arg);
+ dev_dbg(&client->adapter->dev, "i2c ioctl, cmd: 0x%x, arg: %#lx\n", cmd, arg);
switch (cmd) {
case I2C_RETRIES:
adap->retries = arg;


Reported by Emil Svensson on IRC. Sensors-detect would trigger the oops
(through i2c-dev), I could reproduce it easily. Works OK after applying
the patch above.

Please apply,
Thanks.

--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/