Re: [PATCH] runtime PM deadlock

[Andrew Morton]

Alexander Atanasov <alex@xxxxxx> wrote:
>
> 	Hello,
> 
> 	echo -n 3 > /sys/.../power/state; echo -n 2 > /sys/.../power/state
> 
> 	dpm_runtime_suspend holds dpm_sem and calls
> dpm_runtime_resume which deadlocks, instead
> directly call runtime_resume.
> 
> -- 
> have fun,
> alex
> 
> ===== drivers/base/power/runtime.c 1.2 vs edited =====
> --- 1.2/drivers/base/power/runtime.c	Wed Aug 20 09:23:32 2003
> +++ edited/drivers/base/power/runtime.c	Sun Feb 22 18:26:42 2004
> @@ -51,7 +51,7 @@
>  		goto Done;
> 
>  	if (dev->power.power_state)
> -		dpm_runtime_resume(dev);
> +		runtime_resume(dev);
> 
>  	if (!(error = suspend_device(dev,state)))
>  		dev->power.power_state = state;

heh, that's been there since day one.   Thanks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/