Re: [PATCH/proposal] dm-crypt: add digest-based iv generation mode

[James Morris]

On Tue, 24 Feb 2004, Jean-Luc Cooke wrote:

> The two patches are:
>  - http://jlcooke.ca/lkml/ctr_and_omac.patch
>    (added ctr to cipher.c and omac.c)
>    Using the init/update/final interface.
>  - http://jlcooke.ca/lkml/ctr_and_omac2.patch
>    (added ctr to cipher.c and integrated OMAC into all
>    existing modes of operation. If cipher_tfm.cit_omac!=NULL, OMAC is stored
>    into cipher_tfm.cit_omac)

Looks good so far, although the duplicated scatterwalk code needs to be 
put into a separate file (e.g. scatterwalk.c).


> ps. Will crypto_cipher_encrypt/crypto_cipher_decrypt *always* be called in
> onesies?  I need to perform come final() code on the OMAC before it's
> ready to pass test vectors - how do I know when we're done?

I don't understand what you mean here.


Thanks for all this work!


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/