Re: [Kgdb-bugreport] Re: kgdb: rename i386-stub.c to kgdb.c

[Pavel Machek]

Hi!

> >>>kgdb uses really confusing names for arch-dependend parts. This fixes
> >>>it. Okay to commit?
> >>
> >>Why is arch/$x/kernel/$x-stub.c confusing? The name $x-stub.c is 
> >>indicative of architecture dependent code in it. Err, well so is the path.
> >
> >
> >
> >Well, looking at i386-stub.c, how do you know it is kgdb-related?
> >
> >
> >>PPC and sparc stubs in present vanilla kernel use this naming convention. 
> >>That's why I adopted it.
> >>
> >>I find kernel/kgdbstub.c, arch/$x/kernel/$x-stub.c more consistent 
> >>compared to kernel/kgdbstub.c, arch/$x/kernel/kgdb.c
> >
> >
> >I actually made it kernel/kgdb.c and arch/*/kernel/kgdb.c. I believe
> >there's no point where one could be confused....
> 
> gdb itself gets confused with this.  Try, for example, time.c which, on the 
> x86, is in both arch and common code.  I use emacs with kgdb and it gets 
> confused when I point at a location in the source and tell it to set a 
> break point.

That's a gdb bug, surely?

My gdb seems to work okay:

(gdb) b time.c:3
Breakpoint 1 at 0xc01e8b30: file fs/ntfs/time.c, line 3.
(gdb) b kernel/time.c:3
Breakpoint 2 at 0xc0122540: file kernel/time.c, line 3.
(gdb)

....that seems more or less right.

> Please, lets have only one of each name.

You can't have that, anyway.. Filenames are already repeating.

Well, I already commited it. It is possible to revert last change, and
we'll get kernel/kgdbstub.c but arch/*/kernel/kgdb.c.
								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/