Re: [PATCH] IPMI driver updates, part 3

[Corey Minyard]

Yes, I see that this is much better.  I'll work on renaming all these 
and switching to module_param, for the 2.6 version.

Thanks,

-Corey

Rusty Russell wrote:

> In message <403A242A.6000802@xxxxxxx> you write:
>  
>
> > +  insmod ipmi_smb_intf.o
> > +	smb_addr=<adapter1>,<i2caddr1>[,<adapter2>,<i2caddr2>[,...]]
> > +	smb_dbg=<flags1>,<flags2>...
> > +	[smb_defaultprobe=0] [smb_dbg_probe=1]
> >    
>
> Please use "modprobe" not "insmod" in examples, and drop the ".o"
> extension.
>
>  
>
> > +When compiled into the kernel, the addresses can be specified on the
> > +kernel command line as:
> > +
> > +  ipmi_smb=[<adapter1>.]<addr1>[:<debug1>],[<adapter2>.<addr2>[:<debug1>]....
> >    
>
> I realize this is traditional.  However, I suggest you:
> 1) Rename the module to impi_smb.
> 2) Change the variable names to addr, debug, debug_probe and
>   default_probe.
> 3) Change MODULE_PARM to module_param
> 4) Get rid of the #ifndef MODULE code.
>
> The results will be symmetry, and less code:
>
> 	modprobe ipmi_smb addr=<adapter1>,<i2caddr1>[,<adapter2>,<i2caddr2>[,...]]
> 		debug=<flags1>,<flags2>...
> 		default_probe=0 debug_probe=1
>
> and
>
> 	boot ipmi_smb.addr=... ipmi_smb.debug=... ipmi.default_probe=0 ipmi.debug_probe=1
>
> Of course, if you really want to you can use module_param_named and
> keep the variable names the same as they are now, and "#undef
> KBUILD_MODNAME // #define KBUILD_MODNAME ipmi_smb", to avoid renaming
> your module.
>
> But I really think the module name wants a revisit (although I have no
> idea what it does, so might be wrong).
>
> Cheers!
> Rusty.
> --
>  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
>  


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/