Re: Badness in remove_proc_entry called fromsnd_via82xx_remove (2.6.4-mm)

[Alexander Nyberg]

On Thu, 2004-03-11 at 20:04, Takashi Iwai wrote:
> At Thu, 11 Mar 2004 18:38:16 +0100,
> Alexander Nyberg wrote:
> > 
> > This happens at shutdown when alsa is to be closed with kernel 2.6.4-mm.
> > I'm running debian sid, snd_via82xx compiled as module.
> > Happens also on 2.6.4-rc2-mm1, I can try on more kernels as well if it
> > is not a clear case.
> > 
> > 
> > I slapped a printk on these just before the badness:
> > de->subdir->name = "id", de->name = "card0"
> 
> does the attached patch work?
> 
> 
> --
> Takashi Iwai <tiwai@xxxxxxx>		ALSA Developer - www.alsa-project.org
> --- linux/sound/core/init.c	4 Mar 2004 17:54:06 -0000	1.37
> +++ linux/sound/core/init.c	11 Mar 2004 19:01:42 -0000
> @@ -281,7 +281,7 @@
>  	}
>  	if (card->private_free)
>  		card->private_free(card);
> -	snd_info_free_entry(card->proc_id);
> +	snd_info_unregister(card->proc_id);
>  	if (snd_info_card_free(card) < 0) {
>  		snd_printk(KERN_WARNING "unable to free card info\n");
>  		/* Not fatal error */


Yes it worked, no more badness.

Thanks,
Alex

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/