Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h

From: Adrian Bunk
Date: Tue Mar 16 2004 - 15:29:32 EST


On Tue, Mar 16, 2004 at 11:34:56AM -0800, Linus Torvalds wrote:
>
>
> On Tue, 16 Mar 2004, Russell King wrote:
> > >
> > > What are your thoughts on this?
> >
> > So how do we solve this problem. Should I just merge this change and
> > ask you to pull it? I think that's rather impolite though.
>
> I didn't apply the patch because you said it was untested ;)
>
> I'll happily remove that irq.h include if it really doesn't do anything
> but break things. I'd feel happier about it if somebody said it has been
> tested, though ;)

I removed the irq.h from netpoll.h in a 2.6.5-rc1-mm1 that was compiled
with a i386 .config that compiles as much as possible statically into
the kernel.

There were no compilation problems.

> Linus

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/