Re: "Enhanced" MD code avaible for review

[Jeff Garzik]

Scott Long wrote:
> Jeff Garzik wrote:
> > Modulo what I said above, about the chrdev userland interface, we want
> > to avoid this.  You're already going down the wrong road by creating
> > more untyped interfaces...
> >
> > static int raid0_raidop(mdk_member_t *member, int op, void *arg)
> > {
> >          switch (op) {
> >          case MDK_RAID_OP_MSTATE_CHANGED:
> >
> > The preferred model is to create a single marshalling module (a la
> > net/core/ethtool.c) that converts the ioctls we must support into a
> > fully typed function call interface (a la struct ethtool_ops).
>
> These OPS don't exist soley for the userland ap.  They also exist for
> communicating between the raid transform and metadata modules.

Nod -- kernel internal calls should _especially_ be type-explicit, not 
typeless ioctl-like APIs.


> > One overall comment on merging into 2.6:  the patch will need to be
> > broken up into pieces.  It's OK if each piece is dependent on the prior
> > one, and it's OK if there are 20, 30, even 100 pieces.  It helps a lot
> > for review to see the evolution, and it also helps flush out problems
> > you might not have even noticed.  e.g.
> >         - add concept of member, and related helper functions
> >         - use member functions/structs in raid drivers raid0.c, etc.
> >         - fix raid0 transform
> >         - add ioctls needed in order for DDF to be useful
> >         - add DDF format
> >         etc.
>
> We can provide our Perforce changelogs (just like we do for SCSI).

What I'm saying is, emd needs to be submitted to the kernel just like 
Neil Brown submits patches to Andrew, etc.  This is how everybody else 
submits and maintains Linux kernel code.  There needs to be N patches, 
one patch per email, that successively introduces new code, or modifies 
existing code.

Absent of all other issues, one huge patch that completely updates md 
isn't going to be acceptable, no matter how nifty or well-tested it is...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/