Re: [2.6.4-rc2] bogus semicolon behind if()

[Maciej W. Rozycki]

On Fri, 19 Mar 2004, Thomas Schlichter wrote:

> Well, my timer interrupt goes through the IO-APIC but I do have a functional 
> TSC. Nevertheless my system requires timer_ack to be set... If it isn't, my 
> CPU does not utilize its C2 state...

 Hmm, I wonder if there's any relationship between the state of the local
APIC and your observation.  Can you please see if the following hack
changes anything (this assumes you have your timer IRQ directly connected
to an I/O APIC input)?

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@xxxxxxxxxxxxx, PGP key available        +

--- io_apic.c.macro	2004-03-19 20:13:44.000000000 +0000
+++ io_apic.c	2004-03-19 20:15:23.000000000 +0000
@@ -1613,7 +1613,7 @@ static inline void check_timer(void)
 		timer_ack = 1;
 	else
 		timer_ack = !cpu_has_tsc;
-	enable_8259A_irq(0);
+	disable_8259A_irq(0);
 
 	pin1 = find_isa_irq_pin(0, mp_INT);
 	pin2 = find_isa_irq_pin(0, mp_ExtINT);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/