Re: do we want to kill VM_RESERVED or not? [was Re: 2.6.5-rc1-aa3]

[Andrea Arcangeli]

On Sun, Mar 21, 2004 at 12:49:39PM +0100, Andrea Arcangeli wrote:
> the additional hardness you could remove the BUG_ON on in memory.c at line

I now discovered that WARN_ON exists too, so probably the best is to
simply change that to a WARN_ON (or to a printk). If one will ever do a
pagetable walk again, one has to change that to a BUG_ON by that time.
Kernel will work stable regardless of that condition triggering.

--- x/mm/memory.c.~1~	2004-03-20 22:12:43.000000000 +0100
+++ x/mm/memory.c	2004-03-21 12:59:05.331923016 +0100
@@ -1429,7 +1429,7 @@ retry:
 	 * real anonymous pages, they're "device" reserved pages instead.
 	 */
 	reserved = !!(vma->vm_flags & VM_RESERVED);
-	BUG_ON(reserved == pageable);
+	WARN_ON(reserved == pageable);
 
 	/*
 	 * Should we do an early C-O-W break?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/