Re: 2.6.5-rc1-mm2 and direct_read_under and wb

[Chris Mason]

On Mon, 2004-03-22 at 13:10, Daniel McNeil wrote:
> Andrew and Chris,
> 
> I re-ran the direct_read_under tests over the weekend on ext3 with
> the attached wb_rwsema patch and ran without errors.
> 
> It looks like the same thing as before -- async writebacks are causing
> the sync writebacks to miss pages.
> 
> Thoughts?
> 
This hunk alone should be enough to force the sync writers to find a
page with locked but clean buffers.

diff -rup linux-2.6.5-rc1-mm2.orig/fs/buffer.c linux-2.6.5-rc1-mm2/fs/buffer.c
--- linux-2.6.5-rc1-mm2.orig/fs/buffer.c        2004-03-22 09:51:08.780141187 -0800
+++ linux-2.6.5-rc1-mm2/fs/buffer.c     2004-03-19 16:24:57.000000000 -0800
@@ -1814,8 +1814,7 @@ static int __block_write_full_page(struc
                        lock_buffer(bh);
                } else {
                        if (test_set_buffer_locked(bh)) {
-                               if (buffer_dirty(bh))
-                                       __set_page_dirty_nobuffers(page);
+                               __set_page_dirty_nobuffers(page);
                                continue;
                        }
                }


-chris

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/