Re: VMA_MERGING_FIXUP and patch

From: Andrew Morton
Date: Mon Mar 22 2004 - 14:59:50 EST


Hugh Dickins <hugh@xxxxxxxxxxx> wrote:
>
> Hmm, I wonder, is that safe to be calling set_page_dirty
> from inside the page rmap lock? Andrew?

set_page_dirty() takes ->tree_lock and inode_lock. tree_lock surely is OK
and while I cannot think of any deadlocks which could occur with taking
inode_lock inside the rmap lock, it doesn't sound very nice.

It would of course be best if we could avoid adding a new ranking
relationship between these locks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/