RE: [PATCH][RELEASE] megaraid 2.10.2 Driver

[Bagalkote, Sreenivas]

>> > I don't think you understand how CONFIG_COMPAT works.  
>x86-64 defines it
>> > when it wants it:
>> 
>> But not in 2.4, and this is a 2.4-only patch..
>
>It is?  I didn't see that mentioned anywhere.

My fault. I will be more thorough from now on. Thanks for pointing that out.

>
>Anyway, it's wrong to define LSI_CONFIG_COMPAT based solely on 
>__x86_64__.
>You'd also need to check IA32_EMULATION.  Really, it would be simpler
>to add CONFIG_COMPAT to 2.4.
>

Most of the objections centered around CONFIG_COMPAT issue. If we have 
to support 32-bit applications on lk 2.4, what is the right way to do it?
Any
helpful suggestions are appreciated.

>So you can only copy to the bottom 4GB of user address space? That
>seems like a recipe for disaster. Particularly on ia64.

This interface is only for 32-bit applications. If and when we have 64-bit
apps,
they use a different (new) interface.

>and everything will be fine. Please don't introduce this stupid
>unnecessary LSI_CONFIG_COMPAT. That just makes people say "what the
>**** are they doing?".

May I also respectfully suggest that you don't use any F* or similar words
in
your mails, for the sole reason that our corporate server filters those
mails out.
We had to infer from Christoph's mail that you had responded earlier. We
don't
want to miss your valuable feedback.

Thank you,
Sreenivas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/