Re: 2.6.5-rc1-mm2 and direct_read_under and wb

[Andrew Morton]

Daniel McNeil <daniel@xxxxxxxx> wrote:
>
>  It looks like every place wbc->nonblocking is set to 1, sync_mode
>  is set to WB_SYNC_NONE, but there are places where WB_SYNC_NONE is
>  used and nonblocking is NOT set: 
>  	balance_dirty_pages()
>  	try_to_unuse()
> 
>  So your patch makes balance_dirty_pages() do the lock_buffer()
>  in __block_write_full_page() instead of skipping and redirtying
>  the page.
> 
>  I just making sure I understand.
>  So, WB_SYNC_ALL and nonblocking=1 should never be used?

Correct, setting both WB_SYNC_ALL and nonblocking=1 doesn't make sense.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/