Re: [Swsusp-devel] Re: swsusp problems [was Re: Your opinion on the merge?]

[Pavel Machek]

Hi!

> if/when its needed. I'm also of a mind to not include the original
> text-mode 'nice display' and just use the Bootsplash support.

Yes, that would be great. [Bootsplash is in mainline but is in vendor
kernels => great, vendor kernels get splashscreen with progress bar
and vanilla kernel just plain old dots].

> Of course there's also the point that you're assuming I'm going to
> disappear into the wild blue yonder after it's merged. That assumption
> has no basis from my perspective.

Ok, sorry about that one.

> > Oh and it is enough confusing that it confuses me. Some messages end
> > in dmesg, some do not. User feedback can be done with much less code,
> > and also slightly less confusing for the user, see swsusp1. [We have
> > to switch to another console, anyway; and printing dots is easy.]
> 
> As I said above, much of the code was from debugging and can be removed.
> Nevertheless, the interface is not that confusing:

If it slims down a lot, great. If debugging code is gone, and progress
bar depends on bootsplash, we are left with something that looks like
output from swsusp1, right? And there should be little need to
configure it. Good.

> > Okay, we should probably make suspend more quiet, I can see users
> > badly confused by those hdX: spinning down (etc) messages.
> 
> That's fine, but those messages aren't related to my code.

Yes, thats _my_ todo.

> > Also, in your model, where do messages printk()-ed from drivers during
> > suspend/resume end up? Corrupting screen? Lost from sight and only
> > accessible from dmesg? I believe driver messages *are* important, and
> > do not see how they could coexist with eye-candy.
> 
> They do go in the logs. An important exception though (which applies to
> all implementations): messages displayed after the atomic copy is made
> (while suspending) or before the kernel is copied back (resuming) as
> lost because the printk buffer is overwritten,

Yes, but with eye candy its a bit more of a problem because progress
bar updating could obscure them.
								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/