Re: [PATCH][2.6-mm] early_param console_setup clobbers commandline

[Zwane Mwaikambo]

On Fri, 2 Apr 2004, Tom Rini wrote:

> This shouldn't be a problem 'tho, since we don't allow for spaces in
> args, and we do find where the next space is, and ensure it's still a
> space after the call (because console can splice up the command line,
> but we'd skip over those bits anyhow).

Another new thing is that all setup functions get called with their
parameter and any other trailing arguments. So console_setup sees;

tty0 console=ttyS0,38400 hugepages=20 nmi_watchdog=2

That's different enough to cause potential problems in future.

> pci= will clobber as well, which is why I thought I asked Andrew to drop
> that part of the i386 patch (but perhaps I forgot, and with Rusty's
> patch, it becomes a non-issue again).

What is the patch name for Rusty's patch?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/