Re: [PATCH] 2.6.5-aa1 arch updates

[Andrea Arcangeli]

On Sun, Apr 04, 2004 at 02:48:15PM +0100, Hugh Dickins wrote:
> I've gone through our arch and include/asm files checking differences,
> here's a patch to 2.6.5-aa1: page_mapping(page) and prio_tree updates.
> All uncompiled and untested, but probably better than certainly wrong.
> 
> One fix: your ppc64 pte_alloc_one forgot to return NULL on failure:
> I notice that's a __GFP_REPEAT allocation, but even those fail when
> OOM-killed - I find its alias __GFP_NOFAIL very misleading.

this is greatly appreciated, thanks!

> I forget where you stand now on the ppc pgtable stuff: it naturally
> shows up here again, ignore again if you're sure it's irrelevant.

I'm unsure about the arch/ppc/mm/pgtable.c part, I mean, ppc is being
tested heavily, how can it be necessary if nobody ever got an oops yet? 
OTOH your patch certainly cannot hurt and it might be needed after all.
Maybe I should apply it after all, it'd be nice to get a comment on this
bit from ppc people who knows tlb.c better to be sure.

The rest is definitely necessary of course (especially the return NULL
on ppc64 ;).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/