Re: 2.6.5-mm1

[Sid Boyce]

Tom Rini wrote:

> On Mon, Apr 05, 2004 at 01:33:07PM +0100, Sid Boyce wrote:
>
>  
>
> > CC      arch/x86_64/kernel/setup.o
> > arch/x86_64/kernel/setup.c:258: warning: initialization from 
> > incompatible pointer type
> > arch/x86_64/kernel/setup.c: In function `setup_arch':
> > arch/x86_64/kernel/setup.c:411: error: `saved_command_line' undeclared 
> > (first use in this function)
> > arch/x86_64/kernel/setup.c:411: error: (Each undeclared identifier is 
> > reported only once
> > arch/x86_64/kernel/setup.c:411: error: for each function it appears in.)
> > make[1]: *** [arch/x86_64/kernel/setup.o] Error 1
> > make: *** [arch/x86_64/kernel] Error 2
> > -------------------------------------------------------------------
> > strlcpy(saved_command_line, early_command_line, COMMAND_LINE_SIZE);
> >    
>
> Yes, something like this is needed, on top of Rusty's early_param patch:
> diff -puN include/linux/init.h~fix-rusty include/linux/init.h
> --- linux-2.6.5-rc3/include/linux/init.h~fix-rusty	2004-04-02 08:30:50.600483739 -0700
> +++ linux-2.6.5-rc3-trini/include/linux/init.h	2004-04-02 08:30:50.604482833 -0700
> @@ -143,6 +143,7 @@ extern void setup_arch(void);
>
> /* Relies on saved_command_line being set */
> void __init parse_early_options(void);
> +extern char saved_command_line[];
> #endif /* __ASSEMBLY__ */
>
> /**
>
> Assuming that is, that arch/x86_64/kernel/setup.c has #include
> <linux/init.h>, which I assume it does.
>
>  
That fixes it.
Regards
Sid.

--
Sid Boyce .... Hamradio G3VBV and keen Flyer
Linux Only Shop.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/