Re: [linux-usb-devel] 2.6.6-rc1: cdc-acm still (differently) broken

[David Brownell]

Hi Colin,

> Here's another patch, which fixes the leak. It also fixes the
> FIXME, by looking at all interfaces to find the data one. Is it correct ?

It's looking better, but what I'd rather see is code scanning the
CDC descriptors (see "usbnet").  The deal is that there's actually
no guarantee that there's only one data interface, although that
seems to hold true for many current products.

But unless you're interested in finishing a much-needed rewrite
of that cdc-acm probe() code, this might be a good place to stop.
(Or at least pause!)

- Dave



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/