Re: [Fwd: [PATCH] ppc64: Fix CPU hot unplug deadlock]

[Olaf Hering]

 On Sun, Apr 18, Benjamin Herrenschmidt wrote:

> My RTAS locking fixes incorrectly added a spinlock around the function
> used to stop a CPU, that function never returns, thus the lock becomes
> stale. The correct fix is to disable interrupts instead (the RTAS params
> beeing per-CPU, this should be safe enough)
> 
> Ben.
> 
> diff -urN linux-2.5/arch/ppc64/kernel/rtas.c ppc64-linux-2.5/arch/ppc64/kernel/rtas.c
> --- linux-2.5/arch/ppc64/kernel/rtas.c	2004-04-17 12:39:03.253986984 +1000
> +++ ppc64-linux-2.5/arch/ppc64/kernel/rtas.c	2004-04-18 15:35:41.871029480 +1000
> @@ -504,9 +504,9 @@
>  void rtas_stop_self(void)
>  {
>  	struct rtas_args *rtas_args = &(get_paca()->xRtas);
> -	unsigned long s;
>  
> -	spin_lock_irqsave(&rtas.lock, s);
> +	local_irq_disable(s);

did that compile ok for you?

-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, nÃRNBERG
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/