Re: [patch] config option to make at keyboards beep when too many keys are pressed

[Willy Tarreau]

On Sun, Apr 18, 2004 at 09:49:53PM -0400, ameer armaly wrote:

> +#else
> +printk(KERN_ALERT, "\007");
> +#endif			goto out;

Not speaking about poor indentation, this is not the right solution. You
will pollute system logs with \007, and you might even send the beep far
away from the keyboard, if the console is on a serial terminal. A better
solution would be to call a function which activates the local speaker,
typically the one used to output "\007" on a vt.

> +config BEEP_TOMANEY_KEYS
> +bool "Beep when too many keys are pressed on at keyboards"
> +depends on KEYBOARD_ATKBD

please respect indentation here too, just as it is below :

>  config KEYBOARD_SUNKBD
>  	tristate "Sun Type 4 and Type 5 keyboard support"
>  	depends on INPUT && INPUT_KEYBOARD

Regards,
Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/