Re: orinoco potentially dereferencing before check

[Jeff Garzik]

David Gibson wrote:
> On Fri, Apr 16, 2004 at 10:18:26PM +0100, Dave Jones wrote:
>
> > +++ linux-2.6.5/drivers/net/wireless/orinoco_pci.c	2004-04-16 22:17:30.000000000 +0100
> > @@ -275,14 +275,16 @@
> > static void __devexit orinoco_pci_remove_one(struct pci_dev *pdev)
> > {
> > 	struct net_device *dev = pci_get_drvdata(pdev);
> > -	struct orinoco_private *priv = dev->priv;
> > +	struct orinoco_private *priv;
> >
> > 	if (! dev)
> > 		BUG();
> >
> > +	priv = dev->priv;
> > +
> > 	unregister_netdev(dev);
> >
> > -        if (dev->irq)
> > +	if (dev->irq)
> > 		free_irq(dev->irq, dev);
> >
> > 	if (priv->hw.iobase)
> > -
>
>
> Better to just remove the if (! dev) BUG().  I don't believe we've
> ever hit that particular BUG() in debugging, so there's probably not
> much point having it.


done.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/