Re: [linux-usb-devel] [PATCH 1/9] USB usbfs: take a reference tothe usb device

[David Brownell]

Heh ... I like this, getting rid of more of locks from usbcore.


Duncan Sands wrote:
>   In later steps we can
> (1) turn dev->serialize into a rwsem

That doesn't bother me (unlike some folk!) but I do
agree it should wait until the rest shakes out, and
until we can observe benefits.  Hardly any code paths
need complete mutual exclusion (writelock).


> (2) push the acquisition of dev->serialize down to the lower levels as they are fixed up.

Actually at least some of those lower levels are getting
fixed by pushing the lock acquisition up.

The reason usbfs needs to get involved in that stuff is
that it's going around the standard usb driver structure.
One of the other things that "usbfs2" should do is act a
lot more like a "normal" device driver, so it plays better
with more of the normal usbcore mechanisms.

- Dave


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/