Re: [PATCH] Kconfig dependancy update for drivers/misc/ibmasm

[Andrew Morton]

Tony Breeds <tony@xxxxxxxxxxxxxxxxxx> wrote:
>
> 
> Hello,
> 	Some weeks ago I saw this compile error posted to lkml:
> 
> ---
> >   LD      .tmp_vmlinux1
> > drivers/built-in.o(.text+0x435e1): In function `ibmasm_register_uart':
> > : undefined reference to `register_serial'
> > drivers/built-in.o(.text+0x43649): In function `ibmasm_unregister_uart':
> > : undefined reference to `unregister_serial'
> > make: *** [.tmp_vmlinux1] Error 1
> > summer@Dolphin:~/pebble/kernel/linux-2.6.4$
> ---
> 
> This was created because ibmasm was set to yes BUT the 8250 was a
> module.  I believe the correct (tested) fix is below.

Seems sane to me, but I'm not sure why this wasn't done originally.  ie, this:

+#ifdef CONFIG_SERIAL_8250
 extern void ibmasm_register_uart(struct service_processor *sp);
 extern void ibmasm_unregister_uart(struct service_processor *sp);
+#else
+#define ibmasm_register_uart(sp)	do { } while(0)
+#define ibmasm_unregister_uart(sp)	do { } while(0)
+#endif

becomes unnecessary with your patch.

Max, any preferences?


> ################################################################################
> --- 2.6.4.clean/drivers/misc/Kconfig	2004-03-11 17:57:23.000000000 +1100
> +++ 2.6.4.noconfig/drivers/misc/Kconfig	2004-03-30 09:32:07.000000000 +1000
> @@ -6,7 +6,7 @@
>  
>  config IBM_ASM
>  	tristate "Device driver for IBM RSA service processor"
> -	depends on X86
> +	depends on X86 && SERIAL_8250
>  	default n
>  	---help---
>  	  This option enables device driver support for in-band access to the
> ################################################################################
> 
> Yours Tony
> 
>         linux.conf.au       http://lca2005.linux.org.au/
> 	Apr 18-23 2005      The Australian Linux Technical Conference!
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> ----- End forwarded message -----
> 
> Yours Tony
> 
>         linux.conf.au       http://lca2005.linux.org.au/
> 	Apr 18-23 2005      The Australian Linux Technical Conference!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/