Re: why change_page_attr on x86 uses __flush_tlb_all

[Pavel Machek]

Hi!

> > 	I would expect __flush_tlb_one (for each page) as a better choice.
> > It'll be nice if someone can hoghlight on  why __flush_tlb_all is used.
> > The kernel version I am referring from is 2.4.18-14
> 
> This works around a bug in some early Athlons with flushing global
> large pages. Also it makes the code slightly simpler and change_page_attr
> is not really performance critical.

Perhaps comment should be added? Otherwise someone is going
to "fix" it sooner or later.
-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/