Re: put_page() tries to handle hugepages but fails

[Andrew Morton]

David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> +		if (put_page_testzero(page))
>  +			free_huge_page(page);

Well yes, but this is assuming that compound pages are always hugetlb pages.

It's true at present, but it doesn't have to always be true.  The cost of
the destructor is zilch, so why not?

Please review the changes which went into 2.6.6-rc2-mm2.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/