[PATCH*] show last kernel-image symbol in /proc/kallsyms

[Randy.Dunlap]

'cat' or 'tail' of /proc/kallsyms (2.6.6-rc2 or -rc3, & probably much
earlier) does not include the last kernel-image symbol (_einittext).

_einittext is the last symbol generated in .tmp_kallsyms2.S
and the symbol count in that file also appears to be correct,
but the iterator code for /proc/kallsyms comes up 1 short somehow.

Here are 2 patches.  Either one of them "fixes" the problem.
Neither of them is the correct fix AFAIK.
Any other suggestions for fixes?

Thanks,
--
~Randy



// linux-266-rc3
// print the last (kernel image) symbol of /proc/kallsyms
// by making the valid symbol count 1 larger than symbols found;

diffstat:=
 scripts/kallsyms.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


diff -Naurp ./scripts/kallsyms.c~incr_count ./scripts/kallsyms.c
--- ./scripts/kallsyms.c~incr_count	2004-04-03 19:38:23.000000000 -0800
+++ ./scripts/kallsyms.c	2004-05-09 16:33:07.000000000 -0700
@@ -127,7 +127,7 @@ write_src(void)
 	printf(".globl kallsyms_num_syms\n");
 	printf("\tALGN\n");
 	printf("kallsyms_num_syms:\n");
-	printf("\tPTR\t%d\n", valid);
+	printf("\tPTR\t%d\n", valid + 1);
 	printf("\n");
 
 	printf(".globl kallsyms_names\n");



// linux-266-rc3
// print the last (kernel image) symbol of /proc/kallsyms
// by using '>' instead of '>=' in the limiting test
// of the iterator.

diffstat:=
 kernel/kallsyms.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


diff -Naurp ./kernel/kallsyms.c~use_gtr_not_geq ./kernel/kallsyms.c
--- ./kernel/kallsyms.c~use_gtr_not_geq	2004-04-03 19:38:21.000000000 -0800
+++ ./kernel/kallsyms.c	2004-05-09 16:00:11.000000000 -0700
@@ -199,7 +199,7 @@ static void reset_iter(struct kallsym_it
 static int update_iter(struct kallsym_iter *iter, loff_t pos)
 {
 	/* Module symbols can be accessed randomly. */
-	if (pos >= kallsyms_num_syms) {
+	if (pos > kallsyms_num_syms) {
 		iter->pos = pos;
 		return get_ksymbol_mod(iter);
 	}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/