Re: [Lhns-devel] Re: [ANNOUNCE] [PATCH] Node Hotplug Support

From: Takayoshi Kochi
Date: Sun May 09 2004 - 21:16:35 EST


From: Keiichiro Tokunaga <tokunaga.keiich@xxxxxxxxxxxxxx>
Subject: [Lhns-devel] Re: [ANNOUNCE] [PATCH] Node Hotplug Support
Date: Mon, 10 May 2004 10:47:25 +0900

> > How does this interoperate with the current NUMA topology already in
> > sysfs today? I don't see any references at all to the current code.
>
> There is no NUMA support in the current code yet. I'll post a
> rough patch to show my idea soon. I'm thinking to regard a
> container device that has PXM as a NUMA node so far.

I've not looking closely into the code, but why do you use "PNP0A05"
for container device?
"PNP0A05" is defined as "Generic ISA devie" in the ACPI spec.

I think "module device (ACPI0004)" sounds more suitable for the
purpose, though I don't know whether your hardware will support it
or not.

Also, assuming devices that have _PXM are nodes sounds a bit too
aggressive for me. For example, something like below is possible.

Device(\_SB) {
Processor(CPU0...) {
Name(_PXM, 0)
}
Processor(CPU1...) {
Name(_PXM, 1)
}

Device(PCI0) {
Name(_PXM, 0)
}
Device(PCI1) {
Name(_PXM,1)
}
}

(I don't know if such an implementation exists, but from the spec,
it is possible)
In this case, OS has to group devices by same number.

Please don't assume specific ACPI AML implementatin as a generic
rule.

---
Takayoshi Kochi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/