Re: [PATCH*] show last kernel-image symbol in /proc/kallsyms

[Randy.Dunlap]

On Mon, 10 May 2004 10:56:06 -0700 Randy.Dunlap wrote:

| On Mon, 10 May 2004 14:14:10 +1000 Rusty Russell wrote:
| 
| | On Mon, 2004-05-10 at 10:14, Randy.Dunlap wrote:
| | > 'cat' or 'tail' of /proc/kallsyms (2.6.6-rc2 or -rc3, & probably much
| | > earlier) does not include the last kernel-image symbol (_einittext).
| | > 
| | > _einittext is the last symbol generated in .tmp_kallsyms2.S
| | > and the symbol count in that file also appears to be correct,
| | > but the iterator code for /proc/kallsyms comes up 1 short somehow.
| | > 
| | > Here are 2 patches.  Either one of them "fixes" the problem.
| | > Neither of them is the correct fix AFAIK.
| | 
| | Ah, I see you are a student of the Morton school of patch extraction. 
| | Well, it worked.
| 
| Well.... yes.
| 
| And thanks for taking time to fix it.
| It now works as expected.  :)

Welllll, almost as expected.  I now see _einittext as hoped and
expected.  However, sometimes I don't see _etext... if it has the
same address as another (previous) symbol, which it can.

so I think that you may want this kind of patch, especially for
CONFIG_KALLSYMS_ALL.

Please apply/merge.

--
~Randy



// linux-266
// Always include the _etext symbol in /proc/kallsyms.

diffstat:=
 scripts/kallsyms.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)


diff -Naurp ./scripts/kallsyms.c~force_etext ./scripts/kallsyms.c
--- ./scripts/kallsyms.c~force_etext	2004-05-09 19:33:21.000000000 -0700
+++ ./scripts/kallsyms.c	2004-05-10 16:01:02.000000000 -0700
@@ -115,7 +115,10 @@ write_src(void)
 		if (!symbol_valid(&table[i]))
 			continue;
 		
-		if (table[i].addr == last_addr)
+		if (table[i].addr == last_addr &&
+		    last_addr != _etext)
+			/* don't duplicate addresses, except always
+			 * make sure that _etext is in kallsyms */
 			continue;
 
 		printf("\tPTR\t%#llx\n", table[i].addr);
@@ -140,7 +143,8 @@ write_src(void)
 		if (!symbol_valid(&table[i]))
 			continue;
 		
-		if (table[i].addr == last_addr)
+		if (table[i].addr == last_addr &&
+		    last_addr != _etext)
 			continue;
 
 		for (k = 0; table[i].sym[k] && table[i].sym[k] == prev[k]; ++k)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/