Re: From Eric Anholt:

[Greg KH]

On Tue, May 11, 2004 at 08:07:09PM -0400, Daniel Jacobowitz wrote:
> On Tue, May 11, 2004 at 04:43:29PM -0700, Greg KH wrote:
> > On Tue, May 11, 2004 at 07:34:39PM -0400, Valdis.Kletnieks@xxxxxx wrote:
> > > On Wed, 12 May 2004 00:20:51 BST, Dave Airlie said:
> > > 
> > > > I just looked at drm.h and nearly all the ioctls use int, this file is
> > > > included in user-space applications also at the moment, I'm worried
> > > > changing all ints to __u32 will break some of these, anyone on DRI list
> > > > care to comment?
> > > 
> > > Is this a case where somebody is *really* including kernel headers in userspace
> > > and we need to smack them, or are they using a copy that's been sanitized
> > > (and possibly fixed)?
> > 
> > Don't know, but how are you dealing with the issue that an "int" is
> > different for different kernel sizes (64 vs 32) and userspace too.
> > That's why you can't use it in an ioctl and expect things to work
> > properly.
> 
> I'm not disagreeing that it ought to use __u32, but are there any Linux
> supported targets that don't have a 32-bit int?  It's long that tends
> to change size.

I don't think so, but I am not sure.  That's why you should use __u32 to
keep people from guessing :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/