Re: [PATCH] [2.6] Make reiserfs not to crash on oom

[Oleg Drokin]

Hello!

On Wed, May 12, 2004 at 07:01:45PM +0100, Dave Jones wrote:
>  >   Thanks to Standford guys, a case where reiserfs can dereference NULL pointer
>  >   if memory allocation fail during mount was identified.
>  > 
>  > @@ -2260,8 +2260,10 @@
>  >      INIT_LIST_HEAD (&SB_JOURNAL(p_s_sb)->j_prealloc_list);
>  >      INIT_LIST_HEAD(&SB_JOURNAL(p_s_sb)->j_working_list);
>  >      INIT_LIST_HEAD(&SB_JOURNAL(p_s_sb)->j_journal_list);
>  > -    reiserfs_allocate_list_bitmaps(p_s_sb, SB_JOURNAL(p_s_sb)->j_list_bitmap, 
>  > - 				   SB_BMAP_NR(p_s_sb)) ;
>  > +    if (reiserfs_allocate_list_bitmaps(p_s_sb,
>  > +				       SB_JOURNAL(p_s_sb)->j_list_bitmap, 
>  > + 				       SB_BMAP_NR(p_s_sb)))
>  > +	goto free_and_return ;
>  >      allocate_bitmap_nodes(p_s_sb) ;
> Are you leaking the 'journal' allocation here?
> (Ditto some of the other failure paths too)

No, there is "vfree(SB_JOURNAL(p_s_sb)) ;" at the end of free_journal_ram()
that is called if we jump to that free_and_return label.

> There's also a typod 'jornal' a few lines further down.

Yup. Fortunatelly it does not break anything ;)
If somebody to catch all typos and misspellings in reiserfs code, that would
worth a separate patch (and it will be big).

Bye,
    Oleg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/