Re: More convenient way to grab hugepage memory

From: Muli Ben-Yehuda
Date: Thu May 13 2004 - 01:13:58 EST


On Thu, May 13, 2004 at 03:55:20PM +1000, David Gibson wrote:

> --- working-2.6.orig/mm/mmap.c 2004-04-20 10:50:09.000000000 +1000
> +++ working-2.6/mm/mmap.c 2004-04-27 13:40:01.062285976 +1000
> @@ -21,6 +21,7 @@
> #include <linux/profile.h>
> #include <linux/module.h>
> #include <linux/mount.h>
> +#include <linux/err.h>
>
> #include <asm/uaccess.h>
> #include <asm/pgalloc.h>
> @@ -62,6 +63,9 @@
> EXPORT_SYMBOL(sysctl_max_map_count);
> EXPORT_SYMBOL(vm_committed_space);
>
> +int mmap_use_hugepages = 0;
> +int mmap_hugepages_map_sz = 256;

These two global variables do not appear to be used anywhere in this
patch?

> +static inline unsigned long __do_mmap_pgoff(struct file * file, unsigned long addr,

__do_mmap_pgoff seems rather long to be inline?

Cheers,
Muli
--
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/

Attachment: signature.asc
Description: Digital signature