Re: [2.6 patch] fix aic7xxx_old.c for !PCI

From: Adrian Bunk
Date: Thu May 13 2004 - 07:38:39 EST


On Thu, May 13, 2004 at 09:41:53AM +0200, Arjan van de Ven wrote:
> On Thu, 2004-05-13 at 01:55, Adrian Bunk wrote:
> > I got the following compile error in 2.6.6-mm1 (but it's not specific to
> > -mm) with CONFIG_PCI=n:
>
> or how about just providing a dummy pci_release_regions() for the !PCI
> case ?

There's no dummy pci_request_regions(), and it might be hard to find a
return value for a dummy pci_request_regions() that covers all cases.

I'm not religious about this issue, but a dummy pci_release_regions()
without a dummy pci_request_regions() is a bit asymmetric.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/