Re: [PATCH] AES i586 optimized, regparm fixed

[Christoph Hellwig]

On Fri, May 14, 2004 at 03:07:24PM +0200, Fruhwirth Clemens wrote:
> The patch posted yesterday has had an issue with CONFIG_REGPARM. The
> following patch corrects this issue and works for both cases
> CONFIG_REGPARM=y||n. Thanks to Christophe Saout, who pointed out the
> solution almost instantly. The patch does not apply Christophe's patch, but
> rather forces the interface back to regparm(0).

We usually use asmlinkage instead of __attribute__((regparm(0))).  while
it's not nessecary for x86-specific code to abstract this out it at least
looks cleaner.  BTW, is the assembly code shared with some other project?
If not it might be a good idea to kill the ifdefs in there.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/