Re: [PATCH] befs (1/5): LBD support

[Jörn Engel]

On Fri, 14 May 2004 20:09:36 +0400, Sergey S. Kostyliov wrote:
> On Friday 14 May 2004 19:22, Will Dyson wrote:
> > 
> >   Are you interested in taking over official maintainership?
> 
> Yes, I am interested. How do you like this patch?

Good to know.  How do you like this patch?

Jörn

-- 
A quarrel is quickly settled when deserted by one party; there is
no battle unless there be two.
-- Seneca


Simply thinko:
inode->i_flags should never contain fs-specific flags.  In fact, it doesn't;
the checks against it cause "chattr +T" to be useless for ext[23].  Same
bug was in befs as well.

 linuxvfs.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


--- linux-2.6.5cow/fs/befs/linuxvfs.c~befs_inode_flags	2004-04-27 16:34:51.000000000 +0200
+++ linux-2.6.5cow/fs/befs/linuxvfs.c	2004-04-27 16:48:54.000000000 +0200
@@ -376,7 +376,7 @@
 	befs_ino->i_attribute = fsrun_to_cpu(sb, raw_inode->attributes);
 	befs_ino->i_flags = fs32_to_cpu(sb, raw_inode->flags);
 
-	if (S_ISLNK(inode->i_mode) && !(inode->i_flags & BEFS_LONG_SYMLINK)) {
+	if (S_ISLNK(inode->i_mode) && !(befs_ino->i_flags & BEFS_LONG_SYMLINK)){
 		inode->i_size = 0;
 		inode->i_blocks = befs_sb->block_size / VFS_BLOCK_SIZE;
 		strncpy(befs_ino->i_data.symlink, raw_inode->data.symlink,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/