Re: Linux 2.6.6 "IDE cache-flush at shutdown fixes"

[Bartlomiej Zolnierkiewicz]

On Saturday 15 of May 2004 02:59, Andrew Morton wrote:
> Pavel Machek <pavel@xxxxxx> wrote:
> > > > It's a bit grubby, but we could easily add a fourth state to
> > > >  `system_state': split SYSTEM_SHUTDOWN into SYSTEM_REBOOT and
> > > > SYSTEM_HALT. That would be a quite simple change.
> > >
> > > Like this.  I checked all the SYSTEM_FOO users and none of them seem to
> > > care about the shutdown state at present.  Easy.
> >
> > Perhaps this should be parameter to device_shutdown? This is quite
> > ugly.
>
> Rather than a parameter to ->shutdown it would be better to add a new
> ->restart method to devices and IDE can implement one of those.
>
> I don't know if it's worth the effort though.  Is any other driver likely
> to want to discriminate between reboot and shutdown?

it seems only drivers/char/watchdog/alim7101_wdt.c
(currently uses reboot notifier for that)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/