Re: [PATCH] HPET driver

[Jeff Garzik]

Andrew Morton wrote:
> Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
> > Andrew Morton wrote:
> >
> > > It's only applicable to 32-bit machines.  I thik I'd prefer to let the
> > > various arch maintainers decide if this is an appropriate implementation.
> >
> >
> > Agreed, though I observe it's mostly 32-bit architectures that are 
> > missing readq() and writeq() implementations...
>
>
> s2io.h has a private readq/writeq implementation, which I'm removing. 
> There are probably others around the place (haven't looked).
>
> This means that architecture implementation of readq()/writeq() becomes
> non-optional.

It should be non-optional, IMO.

The standard {read,write}[bwl] functions are certainly required if you 
need to care about the PCI or ISA busses, at least.  So {read,write}q 
should follow suit.

	Jeff




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/