Re: [RFC/RFT] Raw access to serio ports (1/2)

[Andrew Morton]

Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx> wrote:
>
>  > The return values here are mucked up - this function returns `written'.
> 
>  Or an error code in negative notation - it's the standard practice for
>  read/write. Am I missing something?

You want the function to return -ENODEV if !list->rawdev->serio

	if (!list->rawdev->serio) {
		retval = -ENODEV;
		goto out;
	}
	...
out:
	up(&rawdev_sem);
	return written;
}

But it won't.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/