Re: [PATCH] 5/5: Device-mapper: dm-zero

[Jens Axboe]

On Wed, Jun 02 2004, Christophe Saout wrote:
> Am Mi, den 02.06.2004 um 16:46 Uhr +0100 schrieb Alasdair G Kergon:
> 
> > +	bio_for_each_segment(bv, bio, i) {
> > +		char *data = bvec_kmap_irq(bv, &flags);
> > +		memset(data, 0, bv->bv_len);
> 
> I just noticed, there's a
> 
> 		flush_dcache_page(bv->bv_page);
> 
> missing here.
> 
> > +		bvec_kunmap_irq(bv, &flags);

and even worse, passing bad argument to bvec_kunmap_irq().

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/