Re: [PATCH] OProfile driver in 2.6

From: Philippe Elie
Date: Wed Jun 02 2004 - 11:37:11 EST


On Wed, 02 Jun 2004 at 08:50 +0000, Tom Rini wrote:

> On Wed, Jun 02, 2004 at 11:19:41AM +0200, Jens Schmalzing wrote:
>
> > Hi,
> >
> > I noticed that the driver for the OProfile profiling system, which
> > existed in the linuxppc-2.5-benh tree, is disabled in the mainline,
> > even though the driver still exists. Is there a reason for this? The
> > attached patch re-enables the driver.
>
> Because it has never been picked up, aside from when Ben took it into
> his tree (assuming this is the patch Anton wrote a while back, and not
> a re-write Ben did). BTW, this is missing a hunk I think, unless the
> arch/ppc/kernel/time.c changes have already made it in.

Right there is a missing call to profile_hook(regs); in ppc_do_profile()

regards,
Phil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/