Re: [RFC] Changing SysRq - show registers handling

[Andrew Morton]

Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx> wrote:
>
> Currently SysRq "show registers" command dumps registers and the call
>  trace from keyboard interrupt context when SysRq-P. For that struct pt_regs *
>  has to be dragged throughout entire input and USB systems. Other than passing
>  this pointer to SysRq handler these systems has no interest in it, it is
>  completely foreign piece of data for them and I would like to get rid of it.
> 
>  I am suggesting slightly changing semantics of SysRq-P handling - instread
>  of dumping registers and call trace immediately it will simply post a request
>  for this information to be dumped. When next HW interrupt arrives and is
>  handled, before running softirqs then current stack trace will be printed.
>  This approach adds small overhead to the HW interrupt handling routine as the
>  condition has to be checked with every interrupt but I expect it to be
>  negligible as it is only check and conditional jump that is almost never
>  taken. The code should be hot in cache so branch prediction should work just
>  fine.

Makes sense I guess.

There have been other times when I've needed access to the registers from
within hard IRQ.  But I forget the reason.

It would be more general, although a little slower to do:

DEFINE_PER_CPU(global_irq_regs);

do_IRQ(...)
{
	...
	struct pt_regs **cpu_regs_slot = __get_cpu_var(global_irq_regs);
	struct pt_regs *save = *cpu_regs_slot;
	*cpu_regs_slot = &regs;
	...
	*cpu_regs_slot = save;
}

And to teach the sysrq code to grab *__get_cpu_var(global_irq_regs).

Note that global_irq_regs is only valid if in_interrupt().  The sysrq
handler can be called from process context via /proc/sysrq-trigger and
should bale out if !in_interrupt().

+static inline void sysrq_show_registes(struct pt_regs *pt_regs)

typo.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/