Re: [PATCH] Use msleep in meye driver

[Stelian Pop]

On Thu, Jun 03, 2004 at 10:47:18AM +0200, Arjan van de Ven wrote:

> 
> > >From what I see in kernel/timer.c, msleep() cannot be called in
> > interrupt context, so the in_interrupt() test must stay.
> 
> mdelay in irq context is *EVIL* though, and will get all the low latency
> and audio folks very upset...

Indeed :)

In fact, reading the code again shows that wait_ms() is never called
in interrupt context, so the in_interrupt() test was useless.

Daniel's patch is then correct, please apply it.

Or should I add a "Signed-off" line too and resend the patch ?

Stelian.
-- 
Stelian Pop <stelian@xxxxxxxxxx>    
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/