Re: [PATCH] CRIS architecture update

[Sam Ravnborg]

On Fri, Jun 04, 2004 at 07:46:21AM +0200, Mikael Starvik wrote:
> Hi,
> 
> >Who reviewed the ethernet driver?
> >Who reviewed the IDE driver?
> >Has Bart seen this new driver?
> >Why was this committed without first being run by the subsystem
> maintainers?
> 
> I am very happy if people outside Axis can find time to review patches
> that only affects the CRIS architecture (note that all files are under
> arch/cris and there is no way you can get these drivers unless you run 
> CRIS). I have assumed that people like you and Bart have too much on 
> your hands to do this. The few times I have tried to patch CRIS stuff on 
> LKML the response is usally none.

The general rule is to locate drivers under drivers/, even the arch 
specific ones. This allows for easier grepping after users of a
given API etc.

s390 has their own directory.
arm has their own directory under driver/net/ etc.

With respect to patches, a very good approach is to follow same style
as is done for s390.
Smaller logical splitted patches, being sent out after each kernel release.
This allows LKML readers to do peer review of changes to the IDE driver,
without having to step over a lot of unrelated code.

General rule is to make easy for the reader.


	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/